Feat(eos_designs): Add static_routes data model under svis in network services #5240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5240
# Activate the virtual environment
source test-avd-pr-5240/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@feat/eos_designs/svi_static_routes#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,feat/eos_designs/svi_static_routes --force
# Optional: Install AVD examples
cd test-avd-pr-5240
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
state: CI Updated
laxmikantchintakindi
force-pushed
the
feat/eos_designs/svi_static_routes
branch
2 times, most recently
from
03f37da to
2449c46
Compare
ClausHolbechArista
requested changes
Apr 4, 2025
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/DC1-BL1A.cfg
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/static_routes.py
Outdated
Show resolved
Hide resolved
laxmikantchintakindi
force-pushed
the
feat/eos_designs/svi_static_routes
branch
3 times, most recently
from
3d68fbd to
c66fef0
Compare
laxmikantchintakindi
force-pushed
the
feat/eos_designs/svi_static_routes
branch
2 times, most recently
from
a257750 to
057beb7
Compare
MaheshGSLAB
reviewed
Apr 10, 2025
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/static_routes.py
Outdated
Show resolved
Hide resolved
MaheshGSLAB
approved these changes
Apr 14, 2025
laxmikantchintakindi
force-pushed
the
feat/eos_designs/svi_static_routes
branch
from
27eff97 to
d46eaa8
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Contributor
|
need a rebase and rerun of molecule. Moving to draft to keep track. |
gmuloc
reviewed
May 12, 2025
laxmikantchintakindi
force-pushed
the
feat/eos_designs/svi_static_routes
branch
from
bc755c0 to
de34aee
Compare
laxmikantchintakindi
force-pushed
the
feat/eos_designs/svi_static_routes
branch
from
907bdd3 to
b78594c
Compare
...s/arista/avd/molecule/eos_designs_unit_tests/intended/configs/evpn_services_l2_only_true.cfg
Outdated
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
May 20, 2025
ClausHolbechArista
dismissed
gmuloc’s stale review
Requested changes has been implemented.
ClausHolbechArista
added
the
one approval
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add static_routes data model under SVI
Related Issue(s)
Partial fix for #4570
Component(s) name
arista.avd.eos_designsProposed changes
User likes to be able to apply static routes only on the l3leafs where the svi (nexthop) is reachable. This can be achieved by create a new designvar 'static_routes' under the 'svi' and 'l3interface' specifically.
How to test
Add static_routes under SVIs.
Checklist
User Checklist
Repository Checklist